packages/react-query-devtools/src/__tests__/ReactQueryDevtoolsPanel.test.tsx (1)

66-75: 💤 Low value

Consider strengthening the onClose assertion.

The test creates a mock onClose function but only verifies that some function was passed to setOnCloseMock, not that the specific onClose prop was forwarded. If the wrapper passes through the function unchanged, you could assert the exact reference. If the wrapper adds logic around onClose, consider testing that invoking the function passed to setOnCloseMock actually calls the original onClose.

♻️ Option 1: Assert exact function if no wrapping occurs

-  expect(setOnCloseMock).toHaveBeenCalledWith(expect.any(Function))
+  expect(setOnCloseMock).toHaveBeenCalledWith(onClose)

♻️ Option 2: Test behavior if wrapping occurs

   expect(setOnCloseMock).toHaveBeenCalledWith(expect.any(Function))
+  
+  // Verify the passed function invokes the original onClose
+  const passedFunction = setOnCloseMock.mock.calls[0][0]
+  passedFunction()
+  expect(onClose).toHaveBeenCalled()

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/react-query-devtools/src/__tests__/ReactQueryDevtoolsPanel.test.tsx`
around lines 66 - 75, The test currently only asserts that setOnCloseMock
received some function; update it to verify the actual onClose behavior: after
rendering ReactQueryDevtoolsPanel with the onClose mock, grab the function
passed into setOnCloseMock (e.g., const passed =
setOnCloseMock.mock.calls[0][0]) and either assert reference equality with the
original onClose (expect(passed).toBe(onClose)) if the prop should be forwarded
unchanged, or invoke passed() and assert the original onClose mock was called
(passed(); expect(onClose).toHaveBeenCalled()) if the wrapper is expected to
wrap the handler; locate these in the ReactQueryDevtoolsPanel test where
QueryClient, onClose, render, and setOnCloseMock are used.